Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Make gridfield search options more accessible #1329

Merged

Conversation

GuySartorelli
Copy link
Member

Add some text to the "advanced" specific search filter dropdown button.
This applies both for searching for pages and searching in a gridfield.

This is following UX advice that came up during the development of silverstripe/silverstripe-framework#10382 - the intention being to make it clearer that there are additional search options (basically advanced search filters, usually, but theoretically these could be used to add arbitrary fields that can be used for arbitrary purposes in a custom SearchContext) available.

image

@emteknetnz
Copy link
Member

@GuySartorelli could you rebase and rebuild bundle.js to resolve merge conflict please

@GuySartorelli GuySartorelli force-pushed the pulls/1/clearer-search-options branch from 3ea7513 to b4d13b4 Compare August 1, 2022 00:32
@GuySartorelli
Copy link
Member Author

GuySartorelli commented Aug 1, 2022

Rebased.

@emteknetnz
Copy link
Member

git diff found modified files when it should not have: D moment-locales/en-SG.js

This sounds familiar, look at the history of this file to see if you get any clues

May need to use git mv if it's a filename capitilisation issue

@GuySartorelli GuySartorelli force-pushed the pulls/1/clearer-search-options branch from b4d13b4 to a1afce4 Compare August 1, 2022 00:41
@GuySartorelli
Copy link
Member Author

GuySartorelli commented Aug 1, 2022

It was just a filename case sensitivity issue. The file content is already exactly the same in the lower-case version, so I've deleted the upper case version. Passing now.

Failing behat tests are unrelated - fixed in #1336

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, tested locally

Before
image

After
image

@emteknetnz emteknetnz merged commit 9366076 into silverstripe:1 Aug 2, 2022
@emteknetnz emteknetnz deleted the pulls/1/clearer-search-options branch August 2, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants