Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Ensure graphql 3 versions of behat tests run #1214

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented May 17, 2021

Issue #1213

Admin is a bit of strange one that runs both 'admin' and 'cms' behat suites. It's debatable whether things should be this way, though for now I think we should keep it as is.

This PR will ensure that both behat suites have both graphql 3 and graphql 4 jobs run

The new graphql 3 behat tests are passing, though the graphql 4 build has an existing failure

.travis.yml Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pull/1.8/behat-graphql branch from be2e92e to 8eec90d Compare May 19, 2021 05:11
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The travis conf looks OK.

The build are still failing however .. it's complaining about

In Schema.php line 1055:
Config contains invalid keys: modelConfig  

If that's an expected failure and it's track somewhere else, feel free to merge.

@emteknetnz
Copy link
Member Author

@maxime-rainville yup graphql4 is existing failure #1215

@emteknetnz emteknetnz merged commit 6a94cc3 into silverstripe:1.8 May 20, 2021
@emteknetnz emteknetnz deleted the pull/1.8/behat-graphql branch May 20, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants