Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken builds - GraphQL 4 - modelConfig #1215

Closed
2 tasks done
emteknetnz opened this issue May 17, 2021 · 3 comments
Closed
2 tasks done

Broken builds - GraphQL 4 - modelConfig #1215

emteknetnz opened this issue May 17, 2021 · 3 comments
Assignees
@maxime-rainville
Labels
affects/v4 complexity/low impact/medium type/bug

Comments

@emteknetnz
Copy link
Member

emteknetnz commented May 17, 2021 •
edited by maxime-rainville
Loading

https://travis-ci.com/github/silverstripe/silverstripe-admin/jobs/505604067 (admin suite)
https://travis-ci.com/github/silverstripe/silverstripe-admin/jobs/505604068 (cms suite, same issue)

We've recently started building the graphql 4 schema at the start of a behat test - silverstripe/silverstripe-graphql#380

This seems to have exposed an issue within admin

In Schema.php line 1055:
  Config contains invalid keys: modelConfig

PRs
@emteknetnz emteknetnz changed the title Broken builds - GraphQL 4 - Broken builds - GraphQL 4 - modelConfig May 17, 2021
@emteknetnz emteknetnz mentioned this issue May 20, 2021
Merged
@emteknetnz emteknetnz self-assigned this Jun 2, 2021
@emteknetnz
Copy link
Member Author

Looks like it's frameworktest - using 0.4.0 instead of the more recent 0.4.2 -- needs this commit silverstripe/silverstripe-frameworktest@3c83a61

@emteknetnz emteknetnz mentioned this issue Jun 3, 2021
Merged
@emteknetnz emteknetnz removed their assignment Jun 3, 2021
@maxime-rainville maxime-rainville mentioned this issue Jun 3, 2021
Merged
This was referenced Jun 8, 2021
Merged
Merged
@maxime-rainville
Copy link
Contributor

All the PRs have been merged ... I've merged up 1.8 into 1. Just waiting to confirm that's green.

@maxime-rainville
Copy link
Contributor

Travis is happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxime-rainville maxime-rainville

Labels
affects/v4 complexity/low impact/medium type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxime-rainville @emteknetnz