Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Remove silverstripe/campaign-admin #93

Merged
merged 1 commit into from
Nov 28, 2024
Merged

DEP Remove silverstripe/campaign-admin #93

merged 1 commit into from
Nov 28, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 20, 2024 •
edited
Loading

@emteknetnz emteknetnz marked this pull request as draft November 20, 2024 05:20
@emteknetnz emteknetnz mentioned this pull request Nov 25, 2024
Closed
15 tasks
@emteknetnz emteknetnz marked this pull request as ready for review November 26, 2024 04:32
GuySartorelli
GuySartorelli approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when the recipe-sink PR is ready to merge.

GuySartorelli
GuySartorelli requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually just realised - there's a reference still in phpunit.xml.dist that needs to be removed.
Also a reference in the readme.

@emteknetnz emteknetnz force-pushed the pulls/6/remove-support branch from c75cea3 to 66fd4f6 Compare November 27, 2024 00:45
@emteknetnz
Copy link
Member Author

Updated

@GuySartorelli GuySartorelli merged commit a2316c4 into silverstripe:6 Nov 28, 2024
7 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/remove-support branch November 28, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli