Update supported modules list for CMS 6

[emteknetnz]

Original issue (private) https://github.com/silverstripeltd/product-issues/issues/884

The list of modules losing commercial support was decided internally within Silverstripe Ltd

Note: At the time this issue is created this list isn't 100% final, though it's unlikely to deviate too much from what's listed here

Modules losing support though will release a 6.0.0 version with CMS 6 then remove from sink

• silverstripe/blog
• silverstripe/subsites
• silverstripe/crontask

Modules losing support

• bringyourownideas/silverstripe-composer-update-checker
• bringyourownideas/silverstripe-maintenance
• cwp/agency-extensions
• cwp/starter-theme
• cwp/watea-theme
• silverstripe/recipe-authoring-tools
• silverstripe/recipe-blog
• silverstripe/recipe-collaboration
• silverstripe/recipe-content-blocks
• silverstripe/recipe-form-building
• silverstripe/recipe-reporting-tools
• silverstripe/recipe-services
• silverstripe/campaign-admin
• silverstripe/auditor
• silverstripe/contentreview
• silverstripe/documentconverter
• silverstripe/elemental-bannerblock
• silverstripe/elemental-fileblock
• silverstripe/environmentcheck
• silverstripe/externallinks
• silverstripe/iframe
• silverstripe/ldap
• silverstripe/registry
• silverstripe/restfulserver
• silverstripe/security-report
• silverstripe/sitewidecontent-report
• silverstripe/versionfeed
• silverstripe/webauthn-authenticator
• symbiote/silverstripe-multivaluefield

Modules to be copied into silverstripe/reports

• silverstripe/externallinks
• silverstripe/security-report
• silverstripe/sitewide-content-report

New issues created

• https://github.com/silverstripeltd/product-issues/issues/887 (private)
• https://github.com/silverstripeltd/product-issues/issues/888 (private)

Acceptance criteria:

• Notes in the CMS 6 docs or changelogs referencing the modules which won't be CMS 6 compatible are removed
• silverstripe/supported-modules is updated
• silverstripe/recipe-kitchen-sink is updated
• https://docs.silverstripe.org/en/6/project_governance/supported_modules/ (CMS 6 version of page) is updated
• 6.0.0 changelog calls out which modules are losing support
• Existing CMS 6 branches are retained (excluding if being copied into silverstripe/reports)
• Relevant code is copied into silverstripe/reports and has its namespaces updated
• 6.0.0 changelogs call out modules copied to silverstripe/reports and updated namespaces
• Supported badges are removed from README.md on the CMS 6 branches
• Rhino does not display CI status for CMS 6 branches
• Ensure that CI crons stop running for unsupported CMS 6 branches when CMS 6 is released (new issue)
• Automatic merge-ups no longer merge-up to unsupported branches
• Rhino does not display merge-up status for CMS 6 branches
• Modules not losing support until CMS 6 are still released with CMS 6
• Create a new issue to remove support for modules not losing support until CMS 6 when CMS 6 has been released

CMS 5 PRs

• API Deprecate campaign admin integrations silverstripe-asset-admin#1514
• API Deprecate campaign admin integrations silverstripe-cms#3028
• DOC Add campaign admin deprecations to changelog developer-docs#635
• API Deprecate campaign admin integrations silverstripe-asset-admin#1517
• API Deprecate campaign-admin config silverstripe-assets#661
• API Deprecate campaign-admin config silverstripe-elemental#1284

Kitchen sink CI

• https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/12059755150

CMS 6 PRs

• ENH Update CMS 6 support supported-modules#46
• DEP Remove silverstripe/campaign-admin recipe-cms#93
• DEP Remove unsupported modules recipe-kitchen-sink#76
• API Remove silverstripe/campaign-admin integration support silverstripe-cms#3027
• API Remove silverstripe/campaign-admin integration support silverstripe-asset-admin#1512
• API Remove silverstripe/campaign-admin integration support silverstripe-admin#1857
• DOC Modules losing commercial support developer-docs#633
• NEW Migrate code from other modules silverstripe-reports#204
• FIX Import correct InputOption class silverstripe-graphql-devtools#65
• FIX Import correct InputOption class symbiote/silverstripe-queuedjobs#452
• DOC Remove mention of webauthn module silverstripe-mfa#577
• MNT Remove webauthn module from behat tests silverstripe-totp-authenticator#177
• MNT Remove commercially supported badge bringyourownideas/silverstripe-composer-update-checker#98
• MNT Remove commercially supported badge bringyourownideas/silverstripe-maintenance#249
• MNT Remove commercially supported badge silverstripe-auditor#96
• MNT Remove commercially supported badge silverstripe-campaign-admin#342
• MNT Remove commercially supported badge silverstripe-contentreview#269
• MNT Remove commercially supported badge silverstripe-documentconverter#101
• MNT Remove commercially supported badge silverstripe-elemental-bannerblock#168
• MNT Remove commercially supported badge silverstripe-elemental-fileblock#60
• MNT Remove commercially supported badge silverstripe-environmentcheck#115
• MNT Remove commercially supported badge silverstripe-iframe#103
• MNT Remove commercially supported badge silverstripe-ldap#96
• MNT Remove commercially supported badge recipe-authoring-tools#43
• MNT Remove commercially supported badge recipe-blog#61
• MNT Remove commercially supported badge recipe-collaboration#39
• MNT Remove commercially supported badge recipe-content-blocks#52
• MNT Remove commercially supported badge recipe-form-building#42
• MNT Remove commercially supported badge recipe-reporting-tools#51
• MNT Remove commercially supported badge recipe-services#42
• MNT Remove commercially supported badge silverstripe-registry#112
• MNT Remove commercially supported badge silverstripe-restfulserver#140
• MNT Remove commercially supported badge silverstripe-versionfeed#124
• MNT Remove commercially supported badge silverstripe-webauthn-authenticator#200
• MNT Remove commercially supported badge symbiote/silverstripe-multivaluefield#122
• MNT Remove commercially supported badge silverstripe-externallinks#155
• MNT Remove commercially supported badge silverstripe-securityreport#90
• MNT Remove commercially supported badge silverstripe-sitewidecontent-report#110
• ENH Remove support for unsupported modules doc.silverstripe.org#312
• DOC Remove campaign-admin reference recipe-plugin#48
• API Remove silverstripe/campaign-admin integration support silverstripe-assets#660
• MNT Remove campaign-admin silverstripe-installer#381
• API Remove silverstripe/campaign-admin integration support silverstripe-versioned#482
• API Remove silverstripe/campaign-admin integration support silverstripe-elemental#1283

[GuySartorelli]

silverstripe/assets has a hide_in_campaigns config in the SilverStripe\Assets\Shortcodes\FileLink class that needs to be removed. Check for any other references to that config as well.

There's also a reference to campaign admin in the readme of recipe-plugin

The SilverStripe\Versioned\ChangeSet model and its associated tests have a bunch of references to campaigns.

• Change the singular and plural name to "Changeset" and "Changesets"
• Remove the CMS_ACCESS_CampaignAdmin permission
• Update phpdocs that refer to campaigns
• Evaluate if there's a quick win way to remove changesets, though they're so heavily embedded in recursive publishing my suspicion is we can't do that easily enough to be worth the effort.

[emteknetnz]

Need a PR to remove the supported badge from:
Need to remove unsupported modules from the sources-*.js
Still need to remove references to these modules from docs

Done

Evaluate if there's a quick win way to remove changeset

Previously looked into this, it's definitely not easy due to recursive publishing. It's more of a Versioning thing that campaign-admin uses, rather than a campaign-admin thing, even though it shouldn't be like this.

silverstripe/assets has a hide_in_campaigns ... etc

Could we perhaps split this one off as a separate card? It's dead code though it doesn't block removing support. Means we can get the sink + alpha sorted quicker

[GuySartorelli]

Could we perhaps split this one off as a separate card? It's dead code though it doesn't block removing support. Means we can get the sink + alpha sorted quicker

I think removing campaign-admin related stuff is explicitly part of this card - but if there's a lot of associated code I could be open to that. My assumption is that there will be minimal if any code related to that config.

[emteknetnz]

Actually doesn't look too bad will do in this card

[GuySartorelli]

Don't know how I missed this last time but:

NEed to remove hide_in_campaigns config from DNADesign\Elemental\Models\ElementalArea

[GuySartorelli]

PRs merged. Reassigning to Steve to check Rhino merge-ups and broken builds tabs display what we expect.

[emteknetnz]

Shiny new sink is green, I think I'll just close this one and we'll deal with broken builds etc as they come up. We've merged lots of CMS 6 things recently so broken things could be because of something else that's been merged

[GuySartorelli]

Rhino does not display CI status for CMS 6 branches

This is the AC I wanted you to check in rhino. @emteknetnz Can you please check that?