Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Hardcode some module versions to installer version #12

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 10, 2022

Issue silverstripe/gha-ci#11

Also moving the 'use parent branch' logic to a more logic place since it's supposed to be used as a fallback

@emteknetnz emteknetnz closed this Jul 11, 2022
@emteknetnz emteknetnz reopened this Jul 11, 2022
@emteknetnz emteknetnz force-pushed the pulls/1.1/hardcode-versions branch from 08e6b3b to a0f3436 Compare July 11, 2022 22:03
@emteknetnz emteknetnz force-pushed the pulls/1.1/hardcode-versions branch from a0f3436 to dae4cd2 Compare July 11, 2022 22:04
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue somewhere to update the release process (or automate during the release process) to add new hardcoded references each release?

consts.php Show resolved Hide resolved
@emteknetnz
Copy link
Member Author

Is there an issue somewhere to update the release process

No. Intention right now is to simply get the initial ci.yml pr's green on the creative-commoners workflows

I honestly don't know how big of an issue this is, or how big of an issue this will be in the future, so I'm unable to create a meaningful actionable issue right now

@GuySartorelli GuySartorelli merged commit df0d941 into silverstripe:1.1 Jul 11, 2022
@GuySartorelli GuySartorelli deleted the pulls/1.1/hardcode-versions branch July 11, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants