Merge pull request #12 from creative-commoners/pulls/1.1/hardcode-ver…

…sions FIX Hardcode some module versions to installer version
silverstripe · Jul 11, 2022 · df0d941 · df0d941
2 parents be81f08 + dae4cd2
commit df0d941
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/consts.php b/consts.php
@@ -106,3 +106,13 @@
         'silverstripe-installer' => '5',
     ],
 ];
+
+const INSTALLER_TO_REPO_MINOR_VERSIONS = [
+    '4.10' => [
+        'html5' => '2.3',
+        'silverstripe-elemental-bannerblock' => '2.4',
+        'silverstripe-session-manager' => '1.2',
+        'silverstripe-userforms' => '5.12',
+        'silverstripe-totp-authenticator' => '4.3',
+    ]
+];
diff --git a/job_creator.php b/job_creator.php
@@ -32,6 +32,14 @@ public function getInstallerVersion(): string
                 return $cmsMajor . '.' . $portions[1] . '.x-dev';
             }
         }
+        // hardcoded installer version for repo version
+        foreach (array_keys(INSTALLER_TO_REPO_MINOR_VERSIONS) as $installerVersion) {
+            foreach (INSTALLER_TO_REPO_MINOR_VERSIONS[$installerVersion] as $_repo => $repoVersion) {
+                if ($repo === $_repo && $repoVersion === $branch) {
+                    return $installerVersion . '.x-dev';
+                }
+            }
+        }
         // fallback to use the latest minor version of installer
         $installerVersions = array_keys(INSTALLER_TO_PHP_VERSIONS);
         $installerVersions = array_filter($installerVersions, fn($version) => substr($version, 0, 1) === $cmsMajor);

diff --git a/tests/JobCreatorTest.php b/tests/JobCreatorTest.php
@@ -126,6 +126,10 @@ public function provideGetInstallerVersion(): array
             ['myaccount/silverstripe-tagfield', 'pulls/burger/myfeature', $latest],
             ['myaccount/silverstripe-tagfield', '2-release', $latest],
             ['myaccount/silverstripe-tagfield', '2.9-release', $latest],
+            // hardcoded repo version
+            ['myaccount/silverstripe-session-manager', '1', $latest],
+            ['myaccount/silverstripe-session-manager', '1.2', '4.10.x-dev'],
+            ['myaccount/silverstripe-session-manager', 'burger', $latest],
         ];
     }