Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC DataList::sort() and orderBy() #123

Merged
merged 1 commit into from
Dec 7, 2022
Merged

DOC DataList::sort() and orderBy() #123

merged 1 commit into from
Dec 7, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Dec 1, 2022
Closed
2 tasks
GuySartorelli
GuySartorelli requested changes Dec 4, 2022
View reviewed changes
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/order-by branch 3 times, most recently from 74e6776 to 631b8bc Compare December 5, 2022 02:19
GuySartorelli
GuySartorelli requested changes Dec 5, 2022
View reviewed changes
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will merge when the framework PR is ready to merge

@GuySartorelli GuySartorelli merged commit 0856641 into silverstripe:5 Dec 7, 2022
@GuySartorelli GuySartorelli deleted the pulls/5/order-by branch December 7, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli