Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out sort() to orderBy() #10449

Closed
2 tasks done
emteknetnz opened this issue Aug 10, 2022 · 1 comment
Closed
2 tasks done

Separate out sort() to orderBy() #10449

emteknetnz opened this issue Aug 10, 2022 · 1 comment

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Aug 10, 2022

DataList Sort() and other ORM method should be split out so that the regular Sort() method cannot accept raw SQL. The new orderBy() and other methods are explicitly designed to accept raw sql

ACs

  • Create new methods
  • Review existing usage of the methods and, if possible, stop using raw sql. If required, use new Raw() methods.

New issues created

Installer CI

PRs

@emteknetnz emteknetnz self-assigned this Nov 30, 2022
@emteknetnz emteknetnz changed the title Separate out Sort() to SortRaw() and other methods Separate out sort() to sortRaw() and other methods Nov 30, 2022
@emteknetnz emteknetnz assigned emteknetnz and unassigned emteknetnz Dec 1, 2022
@emteknetnz emteknetnz changed the title Separate out sort() to sortRaw() and other methods Separate out sort() to orderBy() Dec 1, 2022
@emteknetnz emteknetnz removed their assignment Dec 1, 2022
@GuySartorelli
Copy link
Member

All PRs merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants