Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_cli: fix warning check #1192

Merged
merged 2 commits into from
Oct 25, 2024
Merged

_cli: fix warning check #1192

merged 2 commits into from
Oct 25, 2024

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Oct 25, 2024

This fixes the check added in #1179 by ensuring that we don't bypass the legacy bundle discovery behavior by accident when trying to suppress the warning.

I'll do a bugfix release after this.

This fixes the check added in #1179
by ensuring that we don't bypass the legacy bundle discovery behavior by
accident when trying to suppress the warning.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw added bug Something isn't working component:cli CLI components labels Oct 25, 2024
@woodruffw woodruffw requested a review from jku October 25, 2024 14:43
Signed-off-by: William Woodruff <[email protected]>
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that seems more correcter

@woodruffw woodruffw merged commit 33951a5 into main Oct 25, 2024
25 checks passed
@woodruffw woodruffw deleted the ww/fix-warning-check branch October 25, 2024 14:50
@woodruffw woodruffw mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:cli CLI components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants