Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_cli: don't warn on bare .sigstore if cert/sig is used #1179

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

woodruffw
Copy link
Member

This should fix #1178.

CC @sethmlarson

@woodruffw woodruffw added the component:cli CLI components label Oct 22, 2024
@woodruffw woodruffw self-assigned this Oct 22, 2024
@woodruffw woodruffw requested a review from jku October 22, 2024 14:50
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this branch locally and this fixes the warning in the referenced issue, thanks!

@woodruffw woodruffw enabled auto-merge (squash) October 23, 2024 18:04
@woodruffw woodruffw merged commit f849402 into main Oct 23, 2024
25 checks passed
@woodruffw woodruffw deleted the ww/fix-warning branch October 23, 2024 18:06
@woodruffw woodruffw mentioned this pull request Oct 23, 2024
woodruffw added a commit that referenced this pull request Oct 25, 2024
This fixes the check added in #1179
by ensuring that we don't bypass the legacy bundle discovery behavior by
accident when trying to suppress the warning.

Signed-off-by: William Woodruff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cli CLI components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verification using disjoint materials warns about "bare" Sigstore bundle
3 participants