Add the ability to specify certificate identity via a regular expression #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #234 Signed-off-by: Zach Steindler <[email protected]>
cmurphy
reviewed
Jul 22, 2024
Signed-off-by: Zach Steindler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #234
Cosign allows you to verify bundles signed with a certificate by providing a regular expression to match the certificate identity. Previously, sigstore-go required you to specify the exact certificate identity. This change adds support for sigstore-go to match the certificate identity with a regular expression.
Release Note
verify.NewShortCertificateIdentity()andverify.NewCertificateIdentity()Documentation
N/A