Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify certificates by issuer regex #234

Closed
steiza opened this issue Jul 16, 2024 · 0 comments · Fixed by #236
Closed

Verify certificates by issuer regex #234

steiza opened this issue Jul 16, 2024 · 0 comments · Fixed by #236
Assignees
@steiza
Labels
enhancement New feature or request v1.0 items we want to consider for a v1.0 release

Comments

@steiza
Copy link
Member

steiza commented Jul 16, 2024

Description

When we verify certificates, today we accept:

  • An issuer string (e.g. https://token.actions.githubusercontent.com/)
  • A SAN string (the user or workload identity used in the certificate)
  • A SAN regex (in case you want to support a range of SAN strings)

Noticeably absent is an issuer regex, which is a feature supported by cosign. We should consider adding this capability to sigstore-go.

See #229 (comment) for the initial discussion.
@steiza steiza added enhancement New feature or request v1.0 items we want to consider for a v1.0 release labels Jul 16, 2024
@steiza steiza mentioned this issue Jul 16, 2024
Merged
@steiza steiza self-assigned this Jul 18, 2024
steiza added a commit that referenced this issue Jul 18, 2024
@steiza
Add the ability to specify certificate identity via a regular expression
7c0ed51 
For #234

Signed-off-by: Zach Steindler <[email protected]>
@steiza steiza mentioned this issue Jul 18, 2024
Merged
steiza added a commit that referenced this issue Jul 24, 2024
@steiza
Add the ability to specify certificate identity via a regular express…
a808341 
…ion (#236)

For #234

---------

Signed-off-by: Zach Steindler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steiza steiza

Labels
enhancement New feature or request v1.0 items we want to consider for a v1.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the ability to specify certificate identity via a regular expression sigstore/sigstore-go
1 participant
@steiza