Add mediatype string builder to bundle package #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puerco
changed the title
puerco
changed the title
puerco
force-pushed
the
media-type-string
branch
from
23a2d8d
to
0a944d8
Compare
haydentherapper
requested changes
Apr 23, 2024
pkg/bundle/bundle.go
Outdated
| return "", fmt.Errorf("unable to build media type string, no version defined") | ||
| } | ||
|
|
||
| mtString := fmt.Sprintf("%s+json;version=%s", mediaTypeBase, strings.TrimPrefix(version, "v")) |
There was a problem hiding this comment.
This is dependent on version now, since we made a change to be compliant with OCI as per sigstore/protobuf-specs#165.
v0.1 and v0.2 should be application/vnd.dev.sigstore.bundle+json;version=0.1 and application/vnd.dev.sigstore.bundle+json;version=0.2 respectively, and for v0.3 onwards, application/vnd.dev.sigstore.bundle.v0.%s+json where %s is the trimmed version.
There was a problem hiding this comment.
Ah thanks for the pointer @haydentherapper I was wondering if they were interchangeable. OK, now the function will return the old style for 0.1 - 0.2 and the new one for the rest. I've added cases to test them.
This commit adds a mediatype build string to generate media type strings Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
puerco
force-pushed
the
media-type-string
branch
from
0a944d8
to
8a63eb8
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds a media type string build function to handle the media type string in the module.
With the release of 0.3 all apps relying on the media type constants in
pkg/bundlebroke as the constants were removed in 20c2ce9. This PR introduces a function to generate the media type string from the module and avoid spreading media type strings on applications using the module.Fixes: #153
/cc @codysoyland
Release Note
Added a
bundle.MediaTypeString()function to handle the media type strings from the bundle moduleDocumentation