Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid repeating media type strings #153

Closed
puerco opened this issue Apr 23, 2024 · 0 comments · Fixed by #154
Closed

Avoid repeating media type strings #153

puerco opened this issue Apr 23, 2024 · 0 comments · Fixed by #154
Labels
bug Something isn't working

Comments

@puerco
Copy link
Member

puerco commented Apr 23, 2024

Description

With the release of v0.3 all apps relying on the media type constants in pkg/bundle broke as the constants were removed in 20c2ce9

We should return the (existing) constants and/or add a method to create the bundle media type string to avoid duplicating the strings in all code using the library.

Version

v0.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mediatype string builder to bundle package puerco/sigstore-go
1 participant
@puerco