Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using the swag library for pointer manipulation. #719

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

dlorenc
Copy link
Member

@dlorenc dlorenc commented Mar 8, 2022

And also handle the roothash.

Followup from #718

Signed-off-by: Dan Lorenc [email protected]

Summary

Ticket Link

Fixes

Release Note


And also handle the roothash.

Signed-off-by: Dan Lorenc <[email protected]>
@dlorenc dlorenc requested a review from a team as a code owner March 8, 2022 19:32
@codecov-commenter
Copy link

Codecov Report

Merging #719 (a236c8c) into main (5e5aa9b) will increase coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
+ Coverage   47.50%   47.60%   +0.09%     
==========================================
  Files          65       65              
  Lines        5675     5670       -5     
==========================================
+ Hits         2696     2699       +3     
+ Misses       2688     2681       -7     
+ Partials      291      290       -1     
Impacted Files Coverage Δ
cmd/rekor-cli/app/log_info.go 2.97% <0.00%> (+0.14%) ⬆️
pkg/types/alpine/v0.0.1/entry.go 62.01% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5aa9b...a236c8c. Read the comment docs.

@dlorenc dlorenc merged commit 8cb2ceb into sigstore:main Mar 8, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 8, 2022
@dlorenc dlorenc deleted the swag branch March 8, 2022 19:52
@dlorenc dlorenc mentioned this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants