Make the loginfo command a bit more future/backwards proof. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logid field comes back as nil (which is expected), but we break trying to dereference that for formatting. Signed-off-by: Dan Lorenc <[email protected]>
|
LGTM - just FYI there is a helper library in a dep we have that already implements these sorts of patterns: |
bobcallaway
approved these changes
Mar 8, 2022
I couldn't find anything there that went this direction - it's really useful though for going from string to *string and stuff though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logid field comes back as nil (which is expected), but we break trying
to dereference that for formatting.
Looks like this was introduced in #671
Signed-off-by: Dan Lorenc [email protected]
Summary
Ticket Link
Fixes
Release Note