Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --cert-email actually do something #821

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Make --cert-email actually do something #821

merged 1 commit into from
Sep 29, 2021

Conversation

passcod
Copy link
Contributor

@passcod passcod commented Sep 29, 2021

Summary

Ref #622

The --cert-email option was never actually passed to verify's CheckOpts, so it never did anything.

Release Note

Fixed the `--cert-email` option to actually work

@cpanato cpanato requested a review from dlorenc September 29, 2021 09:57
cpanato
cpanato approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM

@dlorenc dlorenc merged commit 3df9404 into sigstore:main Sep 29, 2021
@github-actions github-actions bot added this to the v1.3.0 milestone Sep 29, 2021
@passcod passcod deleted the make-cert-email-actually-work branch October 4, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@passcod @cpanato @dlorenc