add -cert-email flag to specify an email for a fulcio cert to be valid
#622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice!!! Wdyt about cert-subject instead, to handle the SPIFFE ones? |
I wanted to add that later to make the distinction between the "email" and the "subject" of the cert. We'll also have to give some thought as to the UX for that |
… to be valid Signed-off-by: Jake Sanders <[email protected]>
dlorenc
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #556
(at least partially)
In the long term we'll want to implement the ability to explicitly state expected cert subject(s), but the UX design for that was sticky enough that I wanted to make that change independently.