Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint warning #557

Merged
merged 2 commits into from
Aug 22, 2021
Merged

fix: lint warning #557

merged 2 commits into from
Aug 22, 2021

Conversation

hectorj2f
Copy link
Contributor

Signed-off-by: Hector Fernandez [email protected]

When running lint, we see the following warning message.

WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive.

Hector Fernandez and others added 2 commits August 22, 2021 13:02
Signed-off-by: Hector Fernandez <[email protected]>
Signed-off-by: Dan Lorenc <[email protected]>
@dlorenc
Copy link
Member

dlorenc commented Aug 22, 2021

This change found two existing lint errors. I added a commit to fix those, we can merge after!

@hectorj2f
Copy link
Contributor Author

Thanks @dlorenc. I was out for a while.

@dlorenc dlorenc merged commit 5c70fc4 into sigstore:main Aug 22, 2021
@dlorenc
Copy link
Member

dlorenc commented Aug 22, 2021

No worries!

@hectorj2f hectorj2f deleted the fix_lint_warning branch August 22, 2021 21:22
@cpanato cpanato added this to the v1.1.0 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants