Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: add goreleaser scripts for cosigned #576

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

hectorj2f
Copy link
Contributor

Add scripts to inject scripts to release cosigned binary and its respective docker image using goreleaser.

@cpanato
Copy link
Member

cpanato commented Aug 26, 2021

@hectorj2f missing the DCO :)

@cpanato cpanato requested a review from dlorenc August 26, 2021 12:18
@cpanato
Copy link
Member

cpanato commented Aug 26, 2021

i see that is a helm chart, what we make the release of the chart as well? maybe we push the chart to a dedicated repo. I'm 0/5 on this but just saying will be good to release the chart.

Need some infra for that, but I can take care, did for several other projects already :)

@dlorenc
Copy link
Member

dlorenc commented Aug 26, 2021

Sorry @cpanato not sure I follow - whatever you think is the best way to release this works for me!

@cpanato
Copy link
Member

cpanato commented Aug 26, 2021

the helm chart can be released as well, and for that, we can use the GitHub page to host :) and then we later can publish it to the artifact hub, the whole party

but to release it we will need to do some GitHub actions to deal if the helm.

will work on that.

one question: the image for cosigned is already published?

@@ -70,6 +70,10 @@ steps:
cosign verify-dockerfile -base-image-only -key https://raw.githubusercontent.com/GoogleContainerTools/distroless/main/cosign.pub ./Dockerfile
make sign-container-cloudbuild

cp ./dist/cosigned-linux-amd64 /usr/local/bin/cosigned
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need this, or where we are using this binary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the binary of the webhook server (named cosigned) that we bake within the Docker image of the webhook controller.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the docker build that binary inside the container, my question why do we need to be available outside

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe im missing something

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test locally this is not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hectorj2f
Copy link
Contributor Author

@cpanato Yes, there are two options:
a) Keep the chart here and release it in an automated manner (for that we have to setup the gh pages. I can help you with this).
b) Once we can release the docker image ..., we can do the manual bump of the chart version in https://github.com/sigstore/helm-charts/pull/9/files.

@cpanato
Copy link
Member

cpanato commented Aug 26, 2021

@cpanato Yes, there are two options:
a) Keep the chart here and release it in an automated manner (for that we have to setup the gh pages. I can help you with this).
b) Once we can release the docker image ..., we can do the manual bump of the chart version in https://github.com/sigstore/helm-charts/pull/9/files.

yep! sgtm!

@hectorj2f
Copy link
Contributor Author

hectorj2f commented Aug 26, 2021

yep! sgtm!

Which option do you prefer a) or b) :) ?

one question: the image for cosigned is already published?

@cpanato Nope!

@cpanato
Copy link
Member

cpanato commented Aug 26, 2021

yep! sgtm!

Which option do you prefer a) or b) :) ?

one question: the image for cosigned is already published?

@cpanato Nope!

we will do both, make the release in an automated manner but when we have the image we replace to the new one, for now we can use the one you already pushed

@cpanato
Copy link
Member

cpanato commented Aug 26, 2021

testing this change! 🐻 with me

@cpanato
Copy link
Member

cpanato commented Aug 26, 2021

built everything :)

   • building binaries
      • building                  binary=/cosign/dist/cosign-linux-amd64
      • building                  binary=/cosign/dist/linux-pivkey-amd64_linux_amd64/cosign-linux-pivkey-amd64
      • running hook              hook=apt-get update
      • running hook              hook=apt-get -y install libpcsclite-dev
      • building                  binary=/cosign/dist/cosign-darwin-amd64
      • building                  binary=/cosign/dist/cosign-darwin-arm64
      • building                  binary=/cosign/dist/cosign-windows-amd64.exe
      • building                  binary=/cosign/dist/cosigned-linux-amd64
   • archives
      • skip archiving            binary=cosign-darwin-amd64
      • skip archiving            binary=cosign-windows-amd64.exe
      • skip archiving            binary=cosign-linux-amd64
      • skip archiving            binary=cosign-linux-pivkey-amd64
      • skip archiving            binary=cosigned-linux-amd64
      • skip archiving            binary=cosign-darwin-arm64
   • creating source archive
   • linux packages
   • snapcraft packages
   • calculating checksums
      • checksumming              file=cosign-darwin-arm64
      • checksumming              file=cosign-linux-pivkey-amd64
      • checksumming              file=cosigned-linux-amd64
      • checksumming              file=cosign-linux-amd64
      • checksumming              file=cosign-darwin-amd64
      • checksumming              file=cosign-windows-amd64.exe

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits. made the changes in my local and was able to run a successful release

.goreleaser.yml Outdated Show resolved Hide resolved
@@ -70,6 +70,10 @@ steps:
cosign verify-dockerfile -base-image-only -key https://raw.githubusercontent.com/GoogleContainerTools/distroless/main/cosign.pub ./Dockerfile
make sign-container-cloudbuild

cp ./dist/cosigned-linux-amd64 /usr/local/bin/cosigned
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test locally this is not needed

@cpanato cpanato added this to the v1.2.0 milestone Aug 26, 2021
@hectorj2f hectorj2f requested a review from cpanato August 26, 2021 16:28
@hectorj2f hectorj2f force-pushed the cosigned-releaser branch 2 times, most recently from 4f49469 to 60bdbc1 Compare August 26, 2021 21:54
chart/cosigned/values.yaml Outdated Show resolved Hide resolved
chart/cosigned/values.yaml Outdated Show resolved Hide resolved
@hectorj2f hectorj2f requested a review from cpanato August 27, 2021 12:15
chart/cosigned/Chart.yaml Outdated Show resolved Hide resolved
Signed-off-by: Hector Fernandez <[email protected]>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all!
/lgtm

@dlorenc dlorenc merged commit c791b29 into sigstore:main Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants