-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: add goreleaser scripts for cosigned #576
Conversation
@hectorj2f missing the DCO :) |
i see that is a helm chart, what we make the release of the chart as well? maybe we push the chart to a dedicated repo. I'm 0/5 on this but just saying will be good to release the chart. Need some infra for that, but I can take care, did for several other projects already :) |
751e6e9
to
1b83ded
Compare
Sorry @cpanato not sure I follow - whatever you think is the best way to release this works for me! |
the helm chart can be released as well, and for that, we can use the GitHub page to host :) and then we later can publish it to the artifact hub, the whole party but to release it we will need to do some GitHub actions to deal if the helm. will work on that. one question: the image for |
release/cloudbuild.yaml
Outdated
@@ -70,6 +70,10 @@ steps: | |||
cosign verify-dockerfile -base-image-only -key https://raw.githubusercontent.com/GoogleContainerTools/distroless/main/cosign.pub ./Dockerfile | |||
make sign-container-cloudbuild | |||
|
|||
cp ./dist/cosigned-linux-amd64 /usr/local/bin/cosigned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't need this, or where we are using this binary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the binary of the webhook server (named cosigned) that we bake within the Docker image of the webhook controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the docker build that binary inside the container, my question why do we need to be available outside
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe im missing something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test locally this is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpanato Yes, there are two options: |
yep! sgtm! |
Which option do you prefer a) or b) :) ?
@cpanato Nope! |
we will do both, make the release in an automated manner but when we have the image we replace to the new one, for now we can use the one you already pushed |
testing this change! 🐻 with me |
built everything :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits. made the changes in my local and was able to run a successful release
release/cloudbuild.yaml
Outdated
@@ -70,6 +70,10 @@ steps: | |||
cosign verify-dockerfile -base-image-only -key https://raw.githubusercontent.com/GoogleContainerTools/distroless/main/cosign.pub ./Dockerfile | |||
make sign-container-cloudbuild | |||
|
|||
cp ./dist/cosigned-linux-amd64 /usr/local/bin/cosigned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test locally this is not needed
1b83ded
to
1ae7f58
Compare
4f49469
to
60bdbc1
Compare
60bdbc1
to
a90fe2a
Compare
a90fe2a
to
3a1ef64
Compare
3a1ef64
to
dbc3025
Compare
Signed-off-by: Hector Fernandez <[email protected]>
dbc3025
to
d123f08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for all!
/lgtm
Add scripts to inject scripts to release cosigned binary and its respective docker image using goreleaser.