-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cyclonedx predicate type for attestations #1977
Conversation
Signed-off-by: Josh Dolitsky <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1977 +/- ##
==========================================
- Coverage 34.66% 34.63% -0.04%
==========================================
Files 152 152
Lines 10090 10099 +9
==========================================
Hits 3498 3498
- Misses 6222 6231 +9
Partials 370 370
Continue to review full report at Codecov.
|
@@ -34,6 +34,9 @@ const ( | |||
|
|||
// CosignVulnProvenanceV01 specifies the type of VulnerabilityScan Predicate | |||
CosignVulnProvenanceV01 = "cosign.sigstore.dev/attestation/vuln/v1" | |||
|
|||
// PredicateCycloneDX represents a SBOM using the CycloneDX standard. | |||
PredicateCycloneDX = "https://cyclonedx.org/Document" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not sure the proper value for this. This is based on https://spdx.dev/Document
defined within in-toto: https://github.com/in-toto/in-toto-golang/blob/af1f9fb822bf841779c916a954f651e908c5a818/in_toto/model.go#L81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed this one on in-toto go, we could use the same value here: in-toto/in-toto-golang#169
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puerco awesome, ty. Any reason for /schema
vs. /document
in that PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw your comment there. Just changed to /schema
Signed-off-by: Josh Dolitsky <[email protected]>
Needs a rebase |
Signed-off-by: Josh Dolitsky <[email protected]>
rebased! |
Follow up PR to #1974, but for CycloneDX SBOMs