Add CycloneDX predicate #169
Conversation
This commit adds CycloneDX as a recognized predicate type Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
puerco
force-pushed
the
cyclonedx-predicate
branch
from
dc9c576 to
4a7af4e
Compare
| @@ -79,6 +79,8 @@ const ( | |||
| // The SPDX mandates 'spdxVersion' field, so predicate type can omit | |||
| // version. | |||
| PredicateSPDX = "https://spdx.dev/Document" | |||
| // PredicateCycloneDX represents a CycloneDX SBOM | |||
| PredicateCycloneDX = "https://cyclonedx.org/schema" | |||
There was a problem hiding this comment.
Reason for /schema vs. /Document (as in SPDX version)?
There was a problem hiding this comment.
I think Document in spdx tries to refer to a SPDX document somehow. I pointed the URL to where the CycloneDX schemas live to make it more in line with the other predicate URLs.
|
Bump here, I think things seem reasonable? @puerco @jdolitsky agreed? |
|
lgtm! |
|
Merging! sorry to the long RTT! |
|
Thank you all for a lovely product! "https://cyclonedx.org/schema" does not seem to be the URL of the document. This URL may refer to the correct schema. However, the challenge is that currently, it is not possible to identify the version unless cyclonedx is parsed. I consider the correct URL should be set as a specification. Apologies if this is out of place. |
Fixes issue:
None
Description:
This PR adds CycloneDX as a recognized predicate type
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]
Please verify and check that the pull request fulfills the following
requirements: