-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change impl Into<T> for U
to impl From<U> for T
#5948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! This was just a matter of tech debt, so the cleanup is much appreciated
We can also remove the clippy exception for this:
Line 232 in f1d88ba
-A clippy::from-over-into \ |
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
🛑 The pull request has been removed from the queue
|
@mergify requeue |
☑️ This pull request is already queued |
@mergify unqueue |
✅ The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at a87f19d |
Issue Addressed
Following https://doc.rust-lang.org/std/convert/trait.From.html it is preferred to impl From over Into. There might be specific reasons to using Into in this repository, if so feel free to close the PR.
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.