-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all handler events are covered #5945
Conversation
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
@mergify unqueue |
✅ The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f69ccc3 |
Issue Addressed
Logs indicated an RPC message was being dropped when the shutdown timer expired.
I couldn't see any obvious places where this could happen. The catch-all for this should be in the
poll_close()
. The only case I could think of would be events waiting to be processed in the handler.This PR handles this edge case by ensuring all events are also handled before the handler is completely terminated.
As it stands, this should capture any currently in-flight messages and all events that are remaining to be processed.