[Merged by Bors] - Upgrade to v1.4.0-beta.3 #4862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realbigsean
requested changes
Oct 19, 2023
|
the beacon chain tests are failing for me locally on this branch, not sure what changed here. looks like it's in the data availability overflow cache |
fix overflow tests
realbigsean
approved these changes
Oct 20, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
## Issue Addressed Makes lighthouse compliant with new kzg changes in https://github.com/ethereum/consensus-specs/releases/tag/v1.4.0-beta.3 ## Proposed Changes 1. Adds new official trusted setup 2. Refactors kzg to match upstream changes in ethereum/c-kzg-4844#377 3. Updates pre-generated `BlobBundle` to work with official trusted setup. ~~Using json here instead of ssz to account for different value of `MaxBlobCommitmentsPerBlock` in minimal and mainnet. By using json, we can just use one pre generated bundle for both minimal and mainnet. Size of 2 separate ssz bundles is approximately equal to one json bundle cc @jimmygchen~~ Dunno what I was doing, ssz works without any issues 4. Stores trusted_setup as just bytes in eth2_network_config so that we don't have kzg dependency in that lib and in lcli. Co-authored-by: realbigsean <[email protected]> Co-authored-by: realbigsean <[email protected]>
|
Build failed: |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2023
## Issue Addressed Makes lighthouse compliant with new kzg changes in https://github.com/ethereum/consensus-specs/releases/tag/v1.4.0-beta.3 ## Proposed Changes 1. Adds new official trusted setup 2. Refactors kzg to match upstream changes in ethereum/c-kzg-4844#377 3. Updates pre-generated `BlobBundle` to work with official trusted setup. ~~Using json here instead of ssz to account for different value of `MaxBlobCommitmentsPerBlock` in minimal and mainnet. By using json, we can just use one pre generated bundle for both minimal and mainnet. Size of 2 separate ssz bundles is approximately equal to one json bundle cc @jimmygchen~~ Dunno what I was doing, ssz works without any issues 4. Stores trusted_setup as just bytes in eth2_network_config so that we don't have kzg dependency in that lib and in lcli. Co-authored-by: realbigsean <[email protected]> Co-authored-by: realbigsean <[email protected]>
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
This was referenced Oct 24, 2023
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
## Issue Addressed resolves #4440 ## Proposed Changes restore our `cargo vendor` test in CI changes to `c-kzg` here mean we no longer have to compile it twice and get duplicate source errors: #4862 Co-authored-by: realbigsean <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
## Issue Addressed resolves #4440 ## Proposed Changes restore our `cargo vendor` test in CI changes to `c-kzg` here mean we no longer have to compile it twice and get duplicate source errors: #4862 Co-authored-by: realbigsean <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
## Issue Addressed resolves #4440 ## Proposed Changes restore our `cargo vendor` test in CI changes to `c-kzg` here mean we no longer have to compile it twice and get duplicate source errors: #4862 Co-authored-by: realbigsean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Makes lighthouse compliant with new kzg changes in https://github.com/ethereum/consensus-specs/releases/tag/v1.4.0-beta.3
Proposed Changes
BlobBundleto work with official trusted setup.Using json here instead of ssz to account for different value ofMaxBlobCommitmentsPerBlockin minimal and mainnet. By using json, we can just use one pre generated bundle for both minimal and mainnet. Size of 2 separate ssz bundles is approximately equal to one json bundle cc @jimmygchenDunno what I was doing, ssz works without any issues