-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo vendor with c-kzg crate(s) #4440
Comments
The only workaround I've been able to find in the wild is to publish the same source with different features enabled based on the package name: https://github.com/bodil/im-rs/blob/71331eadac64654bc56f598647ab544197cb1319/build.rs#L14 We would have to make a similar change to the
|
this will be resolved when we can integrate these changes: ethereum/c-kzg-4844#363 |
## Issue Addressed resolves #4440 ## Proposed Changes restore our `cargo vendor` test in CI changes to `c-kzg` here mean we no longer have to compile it twice and get duplicate source errors: #4862 Co-authored-by: realbigsean <[email protected]>
## Issue Addressed resolves #4440 ## Proposed Changes restore our `cargo vendor` test in CI changes to `c-kzg` here mean we no longer have to compile it twice and get duplicate source errors: #4862 Co-authored-by: realbigsean <[email protected]>
## Issue Addressed resolves #4440 ## Proposed Changes restore our `cargo vendor` test in CI changes to `c-kzg` here mean we no longer have to compile it twice and get duplicate source errors: #4862 Co-authored-by: realbigsean <[email protected]>
resolved in #4886 |
Description
Since we import the same dependency twice with different features enabled in
kzg
, we are no longer able to vendor lighthouse deps due to this issue: rust-lang/cargo#10310It looks like there was previously a
--no-merge-sources
flag, but whenvendor
was added as a subcommand tocargo
this was removed. There still existscargo-vendor vendor --no-merge-sources
but I think this requires using rust edition2018
. I wonder if separately publishing thekzg
crate or publishing a mainnet and minimal version of thec-kzg
bindings might let us workaround this?The text was updated successfully, but these errors were encountered: