[Merged by Bors] - Update tiny-bip39 dependency to one implementing zeroize #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
pushed a commit
that referenced
this pull request
Oct 2, 2020
## Issue Addressed Resolves #1130 ## Proposed Changes Use the sigp fork of tiny-bip39, which includes `Zeroize` for `Mnemonic` and `Seed` ## Additional Info N/A
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
paulhauner
pushed a commit
that referenced
this pull request
Oct 3, 2020
## Issue Addressed Resolves #1130 ## Proposed Changes Use the sigp fork of tiny-bip39, which includes `Zeroize` for `Mnemonic` and `Seed` ## Additional Info N/A
bors bot
pushed a commit
that referenced
this pull request
Oct 4, 2020
## Issue Addressed - Resolves #1705 ## Proposed Changes Cleans up some of my TODOs in the code base. - Adds link to issue in this repo for BLST `unsafe` block. - Confirms that the `nextaccount` field *is* required on an EIP-2386 wallet. - Reference: https://github.com/mcdee/EIPs/blob/master/EIPS/eip-2386.md#json-schema - Removes TODO about Zeroize on bip39 that was resolved in #1701 - Removes a TODO about an early randao reveal since we use the slot clock to generate the reveal: https://github.com/sigp/lighthouse/blob/c4bd9c86e6bf23dd66bde150ef85e08caa5e4826/validator_client/src/block_service.rs#L212-L220 ## Additional Info NA
bors bot
pushed a commit
that referenced
this pull request
Oct 5, 2020
## Issue Addressed - Resolves #1705 ## Proposed Changes Cleans up some of my TODOs in the code base. - Adds link to issue in this repo for BLST `unsafe` block. - Confirms that the `nextaccount` field *is* required on an EIP-2386 wallet. - Reference: https://github.com/mcdee/EIPs/blob/master/EIPS/eip-2386.md#json-schema - Removes TODO about Zeroize on bip39 that was resolved in #1701 - Removes a TODO about an early randao reveal since we use the slot clock to generate the reveal: https://github.com/sigp/lighthouse/blob/c4bd9c86e6bf23dd66bde150ef85e08caa5e4826/validator_client/src/block_service.rs#L212-L220 ## Additional Info NA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #1130
Proposed Changes
Use the sigp fork of tiny-bip39, which includes
ZeroizeforMnemonicandSeedAdditional Info
N/A