Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address TODOs #1705

Closed
paulhauner opened this issue Oct 2, 2020 · 1 comment
Closed

Address TODOs #1705

paulhauner opened this issue Oct 2, 2020 · 1 comment
Labels
code-quality

Comments

@paulhauner
Copy link
Member

Description

The codebase has a bunch of TODOs.

Before the review I plan to go through them either clean them up or create issues for them.
@paulhauner paulhauner mentioned this issue Oct 4, 2020
Closed
bors bot pushed a commit that referenced this issue Oct 4, 2020
@paulhauner
Tidy some TODOs (#1721)
82733d8 
## Issue Addressed

- Resolves #1705

## Proposed Changes

Cleans up some of my TODOs in the code base.

- Adds link to issue in this repo for BLST `unsafe` block.
- Confirms that the `nextaccount` field *is* required on an EIP-2386 wallet.
    - Reference: https://github.com/mcdee/EIPs/blob/master/EIPS/eip-2386.md#json-schema
- Removes TODO about Zeroize on bip39 that was resolved in #1701 
- Removes a TODO about an early randao reveal since we use the slot clock to generate the reveal: https://github.com/sigp/lighthouse/blob/c4bd9c86e6bf23dd66bde150ef85e08caa5e4826/validator_client/src/block_service.rs#L212-L220

## Additional Info

NA
bors bot pushed a commit that referenced this issue Oct 5, 2020
@paulhauner
Tidy some TODOs (#1721)
cee3e64 
## Issue Addressed

- Resolves #1705

## Proposed Changes

Cleans up some of my TODOs in the code base.

- Adds link to issue in this repo for BLST `unsafe` block.
- Confirms that the `nextaccount` field *is* required on an EIP-2386 wallet.
    - Reference: https://github.com/mcdee/EIPs/blob/master/EIPS/eip-2386.md#json-schema
- Removes TODO about Zeroize on bip39 that was resolved in #1701 
- Removes a TODO about an early randao reveal since we use the slot clock to generate the reveal: https://github.com/sigp/lighthouse/blob/c4bd9c86e6bf23dd66bde150ef85e08caa5e4826/validator_client/src/block_service.rs#L212-L220

## Additional Info

NA
@paulhauner
Copy link
Member Author

Closed via #1721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulhauner