[Merged by Bors] - Add database schema versioning #1688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
paulhauner
force-pushed
the
v0.3.0-staging
branch
from
55107d0 to
29709c5
Compare
|
Hey I think this might need a |
michaelsproul
force-pushed
the
database-versioning
branch
from
c31cbb6 to
a201722
Compare
|
Done |
|
Added a commit to clarify those 0 keys that everyone stumbles on too 😅 |
michaelsproul
force-pushed
the
database-versioning
branch
from
3207e02 to
336378b
Compare
paulhauner
approved these changes
Sep 30, 2020
|
|
||
| // All the keys that get stored under the `BeaconMeta` column. | ||
| // | ||
| // We use `repeat_byte` because it's a const fn. |
|
Thanks! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 30, 2020
## Issue Addressed Closes #673 ## Proposed Changes Store a schema version in the database so that future releases can check they're running against a compatible database version. This would also enable automatic migration on breaking database changes, but that's left as future work. The database config is also stored in the database so that the `slots_per_restore_point` value can be checked for consistency, which closes #673
|
Pull request successfully merged into v0.3.0-staging. Build succeeded: |
bors
bot
changed the title
paulhauner
pushed a commit
that referenced
this pull request
Oct 1, 2020
## Issue Addressed Closes #673 ## Proposed Changes Store a schema version in the database so that future releases can check they're running against a compatible database version. This would also enable automatic migration on breaking database changes, but that's left as future work. The database config is also stored in the database so that the `slots_per_restore_point` value can be checked for consistency, which closes #673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #673
Proposed Changes
Store a schema version in the database so that future releases can check they're running against a compatible database version. This would also enable automatic migration on breaking database changes, but that's left as future work.
The database config is also stored in the database so that the
slots_per_restore_pointvalue can be checked for consistency, which closes #673