Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle changes to slots_per_restore_point after database initialization #673

Closed
michaelsproul opened this issue Dec 6, 2019 · 2 comments
Closed

Handle changes to slots_per_restore_point after database initialization #673

michaelsproul opened this issue Dec 6, 2019 · 2 comments
Assignees
@michaelsproul
Labels
database

Comments

@michaelsproul
Copy link
Member

Description

At present, Lighthouse assumes that the slots_per_restore_point parameter of the database will remain constant. We should either:

  1. Store it in the DB and warn if the user configures it differently from the value in the DB.
  2. Store it in the DB, and support changing it (up or down) when the user provides a different value.

Option (1) would be easier.
@michaelsproul michaelsproul mentioned this issue Dec 6, 2019
Merged
@michaelsproul michaelsproul self-assigned this Dec 6, 2019
@paulhauner
Copy link
Member

Just following up to see if this is still relevant?

@michaelsproul
Copy link
Member Author

Yeah it still is. I think implementing (1) as a first step makes the most sense.

@ghost ghost added A1 database labels Sep 9, 2020
@michaelsproul michaelsproul mentioned this issue Sep 29, 2020
Closed
bors bot pushed a commit that referenced this issue Sep 30, 2020
@michaelsproul
Add database schema versioning (#1688)
1ad28c0 
## Issue Addressed

Closes #673

## Proposed Changes

Store a schema version in the database so that future releases can check they're running against a compatible database version. This would also enable automatic migration on breaking database changes, but that's left as future work.

The database config is also stored in the database so that the `slots_per_restore_point` value can be checked for consistency, which closes #673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelsproul michaelsproul

Labels
database
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @paulhauner