Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix block check in simulator #1398

Closed
wants to merge 1 commit into from

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Jul 27, 2020

Issue Addressed

Closes #1397

Proposed Changes

This race condition seemed to be cropping up a lot (again in #1381), so I figured I'd fix it ASAP

@michaelsproul michaelsproul requested a review from adaszko July 27, 2020 07:59
@michaelsproul michaelsproul changed the title Fix block check Fix block check in simulator Jul 27, 2020
@michaelsproul michaelsproul added the ready-for-review The code is ready for review label Jul 27, 2020
@michaelsproul
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 27, 2020
## Issue Addressed

Closes #1397

## Proposed Changes

This race condition seemed to be cropping up a lot (again in #1381), so I figured I'd fix it ASAP
@bors bors bot changed the title Fix block check in simulator [Merged by Bors] - Fix block check in simulator Jul 27, 2020
@bors bors bot closed this Jul 27, 2020
@michaelsproul michaelsproul deleted the fix-block-check branch July 27, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulator block production check is racy
2 participants