Skip to content

Commit

Permalink
Fix block check in simulator (#1398)
Browse files Browse the repository at this point in the history
## Issue Addressed

Closes #1397

## Proposed Changes

This race condition seemed to be cropping up a lot (again in #1381), so I figured I'd fix it ASAP
  • Loading branch information
michaelsproul committed Jul 27, 2020
1 parent 5680355 commit edf250c
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions testing/simulator/src/checks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,16 @@ pub async fn verify_full_block_production_up_to<E: EthSpec>(
slot_delay(slot, slot_duration).await;
let beacon_nodes = network.beacon_nodes.read();
let beacon_chain = beacon_nodes[0].client.beacon_chain().unwrap();
let chain_dump = beacon_chain.chain_dump().unwrap();
if chain_dump.len() != slot.as_usize() + 1 {
let num_blocks = beacon_chain
.chain_dump()
.unwrap()
.iter()
.take_while(|s| s.beacon_block.slot() <= slot)
.count();
if num_blocks != slot.as_usize() + 1 {
return Err(format!(
"There wasn't a block produced at every slot, got: {}, expected: {}",
chain_dump.len(),
num_blocks,
slot.as_usize() + 1
));
}
Expand Down

0 comments on commit edf250c

Please sign in to comment.