Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beacon/notifier: display block information for current slot #1084

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

q9f
Copy link
Contributor

@q9f q9f commented Apr 29, 2020

Issue Addressed

N/A

Proposed Changes

Each slot can contain either a block or nothing at all. The normal INFO level sync log should display block hash if there is any or "empty" if there is none.

Additional Info

Screenshot at 2020-04-29 12-44-58

@paulhauner
Copy link
Member

Seems sensible and easily achieved 👍

@paulhauner paulhauner added the enhancement New feature or request label Apr 30, 2020
@paulhauner
Copy link
Member

Oh this is a PR! Sorry assumed it was an issue haha!

Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AgeManning are you cool with this too?

@paulhauner paulhauner requested a review from AgeManning April 30, 2020 00:09
@paulhauner paulhauner added ready-for-review The code is ready for review and removed enhancement New feature or request labels Apr 30, 2020
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good to me also

@paulhauner paulhauner merged commit f4ac042 into sigp:master Apr 30, 2020
@paulhauner
Copy link
Member

Thank you @q9f!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants