beacon/log: augment logs with block roots #5675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested changes
Apr 29, 2020
| "slot": block.Slot, | ||
| "block": fmt.Sprintf("0x%s...", hex.EncodeToString(blockRoot[:])[:8]), | ||
| "epoch": helpers.SlotToEpoch(block.Slot), | ||
| "finalizedEpoch": finalized.Epoch, |
There was a problem hiding this comment.
My argument for this is 99% of users/non developers don't care about finalizedEpoch and finalizedRoot when syncing. So perhaps move it to debug?
There was a problem hiding this comment.
Not seeing the finality is my main pain point. Everyone should care about finality :)
Burying it in DEBUG level would be very unfortunate due to the noise.
There was a problem hiding this comment.
Marinated a bit more with this. I'm on board with this rationale
Codecov Report
@@ Coverage Diff @@
## master #5675 +/- ##
===========================================
+ Coverage 1.47% 39.53% +38.05%
===========================================
Files 69 239 +170
Lines 6492 20865 +14373
===========================================
+ Hits 96 8249 +8153
- Misses 6387 11048 +4661
- Partials 9 1568 +1559 |
terencechain
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR augments sync logs with some additional information that helps identifying the best block and epoch without increasing verbosity but also by avoiding too much log spam.
This PR is the sister of sigp/lighthouse#1084
Which issues(s) does this PR fix?
N/A
Other notes for review
Initial Sync:
New Blocks Received:
