Fix example config for Pulsar exporter, units are nanoseconds #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- setting partitions_auto_discovery_interval to 1 causes a storm of CommandPartitionedTopicMetadata requests to brokers. The broker doesn't log these requests and it's hard to detect the issue. The default value in the client is 1 minute which is 60*10^9. Set the example value to the default. - setting batching_max_publish_delay to 10 will make batching uneffective since the unit is nanoseconds. The default value in the client is 10 milliseconds which is 10^7. Set the example value to the default.
2 tasks
2 tasks
|
That's an excellent finding! Thanks @lhotari time.Duration is in nano seconds |
1 task
pmcollins
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
For the record, the Pulsar exporter in this repo was developed for a very narrow use case and is not really intended for general use. As a result, we really have no way to test this, but since this change is for an example config, I think it's low risk. Thanks for fixing.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting
partitions_auto_discovery_intervalto1causes a flood ofCommandPartitionedTopicMetadatarequests to brokers. The broker doesn't log these requests with info level, and it's hard to detect the issue.setting
batching_max_publish_delayto10will make batching ineffective since the unit is nanoseconds.