Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

ISSUE-18243: Add observability metrics for CommandPartitionedTopicMetadata requests #5053

Open
1 of 2 tasks
sijie opened this issue Oct 28, 2022 · 1 comment
Open
1 of 2 tasks

Comments

@sijie
Copy link
Member

sijie commented Oct 28, 2022

Original Issue: apache#18243


Search before asking

  • I searched in the issues and found nothing similar.

Motivation

Currently, there's no way to track CommandPartitionedTopicMetadata requests. There's no metrics or logs that indicate that a broker is handling CommandPartitionedTopicMetadata requests.

Misconfigured clients might flood brokers with CommandPartitionedTopicMetadata requests and cause high CPU consumption.

One example of this is misconfiguration of splunk-otel-collector's Pulsar exporter. The example config configures pulsar-client-go's PartitionsAutoDiscoveryInterval setting to 1 nanosecond. I have sent a PR to fix the example config with signalfx/splunk-otel-collector#2185 . This example shows that it's easy to mix the units and misconfigure a Pulsar client.

Solution

Add observability metrics for CommandPartitionedTopicMetadata requests, similar to what there is for lookup requests added by apache#8272.

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@tjiuming
Copy link

tjiuming commented Nov 1, 2022

apache#18281

@sijie sijie added the Stale label Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants