don't use deprecated tls.createSecurePair if TLSSocket is avaiable #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. We are using mysql2/promise (now with connection pool) in our project. Unfortunately, we can't reach AWS/RDS (routing reasons, to be short) so I can't test it, sorry. I created a new MySQL server on AWS to try to test your change but I can't find how to connect to it (previously I was able to connect to it but there are some routing issues I don't have time/knowledge to investigate ATM). |
|
No problems @carlok , just thought if you have production setup you could give it a go. I tested with temporary RDS server and it seem to work fine, I'll merge |
This was referenced Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #363
@carlok - would you be able to test this
tlssocketbranch?