Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls.createSecurePair is being runtime-deprecated #11

Closed
ChALkeR opened this issue Feb 26, 2017 · 3 comments
Closed

tls.createSecurePair is being runtime-deprecated #11

ChALkeR opened this issue Feb 26, 2017 · 3 comments

Comments

@ChALkeR
Copy link

ChALkeR commented Feb 26, 2017

Ref: nodejs/node#11349

Used in:

rai-0.1.12.tgz/lib/mockup.js:75:                pair = tlslib.createSecurePair(sslcontext, false);
rai-0.1.12.tgz/lib/starttls.js:40:    pair = require('tls').createSecurePair(sslcontext, true);

See also #8.
See e.g. sidorares/node-mysql2#367 for a feature detection example.

@andris9
Copy link
Owner

andris9 commented Feb 26, 2017

rai module is deprecated as well, it only exists to support the code written for old versions of Node.js.

@andris9 andris9 closed this as completed Feb 26, 2017
@ChALkeR
Copy link
Author

ChALkeR commented Feb 26, 2017

@andris9 Perhaps it should be documented as deprecated, then (i.e. in the Readme and/or via npm deprecate)? Atm, https://www.npmjs.com/package/rai has 137043 downloads per month, which is pretty significant.

@ChALkeR
Copy link
Author

ChALkeR commented Feb 26, 2017

It looks like most downloads come from https://www.npmjs.com/package/simplesmtp, which is documented to be deprecated in the Readme, but has a lot of dependents. Most likely it's worth npm deprecate-ing that module, too (which it isn't now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants