Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack projects no longer show warning for cardinal dependency #1589

Merged

Conversation

mikedidomizio
Copy link

I made a comment here on a fix for the cardinal optional dependency issue with Webpack. I decided to go ahead with the PR as I won't have the configuration set up for too long on my end.

This fixes the issue for at least Webpack, I haven't checked with other bundlers.

I've added a video below to show how my project running Next12/Webpack5 would show the warning, and how after the fix the warning would be gone. On the right is the node-mysql2 project, and the top left console is my project which has it npm linked so I can test changes.

Screen.Recording.2022-07-02.at.7.18.08.PM.1.mov

@sidorares sidorares self-requested a review July 31, 2022 00:19
@sidorares sidorares modified the milestone: 1.0.0 Jul 31, 2022
@mikedidomizio
Copy link
Author

Not sure why the job failed here. I attempted the same PR in my fork and succeeded. I see this other PR hit the same issue. Maybe the limit on GitHub actions minutes?

@sidorares
Copy link
Owner

Not sure why the job failed here. I attempted the same PR in my fork and succeeded. I see this other PR hit the same issue. Maybe the limit on GitHub actions minutes?

known problem - #1585
I might just disable this workflow for now unless there is a better fix

@sidorares sidorares merged commit 2bc513c into sidorares:master Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants