fix: webpack projects no longer show warning for cardinal dependency #1589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a comment here on a fix for the cardinal optional dependency issue with Webpack. I decided to go ahead with the PR as I won't have the configuration set up for too long on my end.
This fixes the issue for at least Webpack, I haven't checked with other bundlers.
I've added a video below to show how my project running Next12/Webpack5 would show the warning, and how after the fix the warning would be gone. On the right is the node-mysql2 project, and the top left console is my project which has it npm linked so I can test changes.
Screen.Recording.2022-07-02.at.7.18.08.PM.1.mov