Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: coverage-comment-action premissions problem #1585

Closed
yuxizhe opened this issue May 30, 2022 · 2 comments
Closed

CI: coverage-comment-action premissions problem #1585

yuxizhe opened this issue May 30, 2022 · 2 comments

Comments

@yuxizhe
Copy link
Contributor

yuxizhe commented May 30, 2022

- name: Display coverage
uses: ewjoachim/coverage-comment-action@v1
with:
COVERAGE_FILE: "Cobertura.xml"
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

there is a bug in coverage-comment-action
ewjoachim/coverage-comment-action#26

external users creating PRs will trigger actions whose github token won't have the right to post comments.

so external users PRs always fail.

eg: https://github.com/sidorares/node-mysql2/runs/6649645051?check_suite_focus=true

github.GithubException.GithubException: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/reference/issues#create-an-issue-comment"}
Operating on refs/pull/1584/merge
Commenting on the coverage on PR 1584
Previous coverage results not found, cannot report on evolution.
@sidorares
Copy link
Owner

I'm thinking to completely disable this workflow unfortunately
Maybe I'll give https://github.com/ewjoachim/python-coverage-comment-action a try first

@sidorares
Copy link
Owner

added continue-on-error: true via #1697 , PRs from external users won't have a coverage message but at least should not see failure if everything else is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants