Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve the premissions problem #26

Open
ewjoachim opened this issue Dec 17, 2021 · 1 comment
Open

Solve the premissions problem #26

ewjoachim opened this issue Dec 17, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@ewjoachim
Copy link
Owner

  • If this action is used as a target of a pull_request event, then external users creating PRs will trigger actions whose github token won't have the right to post comments.
  • The solution would be to split between a pull_request workflow that will compute the message to be posted and store it in an artifact, and a workflow_run workflow that will post the said comment WITHOUT checking out the code.
  • This 2nd workflow will be more sensitive in terms of what it can do, because it will have a write token.
@ewjoachim ewjoachim added the bug Something isn't working label Dec 17, 2021
@ewjoachim
Copy link
Owner Author

So this is solved in https://github.com/ewjoachim/python-coverage-comment-action.

I'm not sure I'm willing to spend a lot of time fixing it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant