Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unnecessary async read with sync one #41

Merged
merged 17 commits into from
Oct 1, 2014
Merged

Conversation

sidorares
Copy link
Owner

this is big refactoring, but hopefully it'll make code much much cleaner.

Since 'yyuua(yv) + body' message size is known after reading first 16 bytes I can read the whole message first and only then parse message buffer. Few reasons behind this:

  • get rid of "binary" module dependency. It was good to start, but after some point become a lot of pain to support ( speed, leaking memory Memory leak from bus.invoke #21 , crazy stack traces and other problems )
  • alignment based on global offset is really difficult to implement in async code

some other changes as part of this PR:

sidorares added a commit that referenced this pull request Oct 1, 2014
Replace unnecessary async read with sync one
@sidorares sidorares merged commit 02112d6 into master Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant