Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not start on Ubuntu 23.10 with wayland #625

Closed
mvivarelli opened this issue Oct 14, 2023 · 10 comments · Fixed by #611
Closed

Does not start on Ubuntu 23.10 with wayland #625

mvivarelli opened this issue Oct 14, 2023 · 10 comments · Fixed by #611
Labels
bug Something isn't working

Comments

@mvivarelli
Copy link

Brief summary of issue

fresh install, install shutter with official ppa (still at 0.99.2), shutter does not start
tried also with 0.99.3 and 0.99.4

@mvivarelli mvivarelli added the bug Something isn't working label Oct 14, 2023
@Photon89
Copy link
Member

This should be fixed in this PR: #611 You can download from https://github.com/shutter-project/shutter/archive/refs/heads/fix_wayland_crash_on_launch.zip, unpack and run from the unpacked directory ./bin/shutter.

@mvivarelli
Copy link
Author

mvivarelli commented Oct 14, 2023 via email

@Photon89
Copy link
Member

It is missing a dependency, libmoo-perl.

@mvivarelli
Copy link
Author

mvivarelli commented Oct 14, 2023 via email

@Photon89
Copy link
Member

Great! To be honest, I stumbled upon your fork around half a year ago and was quite excited, so I mentioned it on our internal mail exchange. As far as I understand, other team members liked it as well, though it seems limited to the Gnome desktop. In the mean time, I have submitted a PR which works on Plasma but not on Gnome: #612 So far it breaks something on X11 though, therefore the draft status. Maybe the combination of the two approaches will be a good solution for our missing Wayland support problem!

Unfortunately, I won't be able to have a look into it till end of the months, but thanks a lot for putting the work into the fix already! 😃

@Photon89 Photon89 linked a pull request Oct 15, 2023 that will close this issue
@mvivarelli
Copy link
Author

mvivarelli commented Oct 16, 2023 via email

@Photon89
Copy link
Member

@mvivarelli Hi, would you mind creating a PR from your fork, so we can have a look whether there are merge conflicts? Thanks!

@mvivarelli
Copy link
Author

mvivarelli commented Dec 27, 2023 via email

@Photon89
Copy link
Member

Photon89 commented Dec 27, 2023

Sure, no problem! 😃 I had a quick look. Not went through the details yet, though. I see two problems we'd have to tackle:

  1. As far as I understand, this only works for Gnome (unless we want to require gnome-screenshot as dependency on all desktops). For KDE there is an alternative solution using slurp. We'd need to somehow determine which environment we are in and use the suiting functions.
  2. As far as I can see, you put all the "dirty work" into fct_gnome_screenshot inside the main file. While it works in principle, the usual placement for it would be in several modules which are placed in /usr/share/shutter/resources/modules/Shutter/Screenshot/. Each screenshot mode (like full screen, window or selection) is placed in one of those modules. So, if we want to follow this design (which we probably should, because otherwise it will get even harder to find something in this mess than it already is), we'd have to take the screenshot mode specific code out of fct_gnome_screenshot and place it into the corresponding modules (existing or newly created ones).

Really sorry to be nagging, but I think, if we just take it as is, it will make life harder on the long run...

@mvivarelli
Copy link
Author

mvivarelli commented Dec 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants