This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
Upgrade demoshop to beta4 version #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
grossmannmartin
commented
Dec 11, 2018
grossmannmartin
commented
| Q | A |
|---|---|
| Description, reason for the PR | Keep demoshop upgraded with newest version of Framework |
| New feature | No |
| BC breaks | No |
| Fixes issues | - |
| Standards and tests pass | Yes |
| Have you read and signed our License Agreement for contributions? | Yes |
vitek-rostislav
suggested changes
Dec 12, 2018
There was a problem hiding this comment.
Hi @grossmannmartin, good job 👍 I have added a few notes so please check them out 🙂
As I mentioned in some of the notes, I think it would be nice to link the original pull requests in the commit messages where it makes sense. I could help with understanding the changes in the project.
tests/ShopBundle/Functional/Component/Doctrine/GroupedScalarHydratorTest.php
Show resolved
Hide resolved
tests/ShopBundle/Functional/Model/Cart/Watcher/CartWatcherServiceTest.php
Show resolved
Hide resolved
tests/ShopBundle/Functional/Model/Pricing/InputPriceRecalculationSchedulerTest.php
Show resolved
Hide resolved
vitek-rostislav
approved these changes
Dec 12, 2018
grossmannmartin
force-pushed
the
mg-beta4-upgrade
branch
from
b192f6a to
699baa8
Compare
vitek-rostislav
approved these changes
Dec 12, 2018
There was a problem hiding this comment.
Hi @grossmannmartin, all the changes are now ok with me 👍 After the tests are done, you can move the task to business validation 🎉
boris-brtan
reviewed
Dec 12, 2018
boris-brtan
reviewed
Dec 13, 2018
- Class DatabaseTestCase was renamed to TransactionFunctionalTestCase (see shopsys/shopsys#541)
- added missing @param and @return annotations through the whole codebase - see shopsys/shopsys#573
- new OrderItemsType for displaying table for order items management - new DisplayOnlyCustomerType for displaying information about Customer - see shopsys/shopsys#576
…, rename) - remove db-fixtures-demo-multidomain and test-db-fixtures-demo-multidomain and their usages - switch dependency order of db-demo to ...,create-domains-data,db-fixtures-demo-singledomain,... - switch dependency order of test-db-demo to ...,test-create-domains-data,test-db-fixtures-demo-singledomain,... - change db-fixtures-demo-singledomain and test-db-fixtures-demo-singledomain command to <arg value="doctrine:fixtures:load" /> as command shopsys:fixtures:load doesn't exist anymore and remove --fixtures argument - rename db-fixtures-demo-singledomain to db-fixtures-demo - rename test-db-fixtures-demo-singledomain to test-db-fixtures-demo
- there is no need to extend twig template anymore - see shopsys/shopsys#576
- overriden data fixtures can be loaded before original, resulting in unwanted data and block loading of original data fixtures fix this problem - see shopsys/shopsys#568
grossmannmartin
force-pushed
the
mg-beta4-upgrade
branch
from
03b0e7a to
7bd9248
Compare
grossmannmartin
force-pushed
the
mg-beta4-upgrade
branch
from
9e8da3a to
8d77412
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.