-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shopsys] add FQN @param, @return and @var everywhere #573
Conversation
packages/framework/src/Component/Doctrine/QueryBuilderService.php
Outdated
Show resolved
Hide resolved
packages/framework/src/Model/AdvancedSearch/AdvancedSearchFilterInterface.php
Outdated
Show resolved
Hide resolved
packages/framework/tests/Unit/Component/UploadedFile/UploadedFileLocatorTest.php
Show resolved
Hide resolved
packages/framework/tests/Unit/Model/Newsletter/NewsletterFacadeTest.php
Outdated
Show resolved
Hide resolved
packages/migrations/src/Component/Doctrine/Migrations/MigrationsFinder.php
Outdated
Show resolved
Hide resolved
d6d8d4a
to
6bd6355
Compare
a6ea9f1
to
59d3b67
Compare
@vitek-rostislav Ready to review, I'll rebase this and retarget to |
59d3b67
to
6c7b0aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TomasVotruba, thank you for the PR. annotations for the win 😄 It looks fine, however, there is one issue that needs to be addressed, please check it out.
microservices/product-search/src/Controller/SearchController.php
Outdated
Show resolved
Hide resolved
One more thing, do you think we should update the upgrading instructions? From a project point of view, if I wanted to start using the new version, I might break my build for example as it might fail on the new standards. So I think we should probably add instruction to run |
af9ec58
to
a8cbd0f
Compare
Well, I'd just add 1 line to
Well, you should always:
So there is no need to create extra notes. |
a8cbd0f
to
6a989db
Compare
…s to easy-coding-standard.yml
…ed and fixed automatically
869865c
to
0d617a4
Compare
- added missing @param and @return annotations through the whole codebase - see shopsys/shopsys#573
- added missing @param and @return annotations through the whole codebase - see shopsys/shopsys#573
Targets #554 branch, not💀master
for clearer diff.Change base branch before merge to
master
✔️ + rebase ✔️How to Apply