Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shopsys] add FQN @param, @return and @var everywhere #573

Merged
merged 5 commits into from
Nov 6, 2018

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Nov 5, 2018

Q A
Description, reason for the PR Pratical application of #554
New feature No
BC breaks No
Standards and tests pass Yes
Have you read and signed our License Agreement for contributions? Yes

⚠️ Targets #554 branch, not master for clearer diff. 💀

Change base branch before merge to master ✔️ + rebase ✔️

How to Apply

vendor/bin/ecs check packages --fix
vendor/bin/ecs check project-base --fix
vendor/bin/ecs check microservices --fix

@TomasVotruba
Copy link
Contributor Author

@vitek-rostislav Ready to review, I'll rebase this and retarget to master after merge of #554

@TomasVotruba TomasVotruba changed the base branch from tv-method-annotations to master November 5, 2018 13:07
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TomasVotruba, thank you for the PR. annotations for the win 😄 It looks fine, however, there is one issue that needs to be addressed, please check it out.

@vitek-rostislav
Copy link
Contributor

vitek-rostislav commented Nov 5, 2018

One more thing, do you think we should update the upgrading instructions? From a project point of view, if I wanted to start using the new version, I might break my build for example as it might fail on the new standards. So I think we should probably add instruction to run php phing standards-fix to let the fixers do their work 🙂

@TomasVotruba TomasVotruba force-pushed the tv-applied branch 2 times, most recently from af9ec58 to a8cbd0f Compare November 5, 2018 22:36
@TomasVotruba
Copy link
Contributor Author

One more thing, do you think we should update the upgrading instructions?

Well, I'd just add 1 line to CHANGELOG.md, that all.

I might break my build for example as it might fail on the new standards. So I think we should probably add instruction to run php phing standards-fix to let the fixers do their work slightly_smiling_face

Well, you should always:

  • rebase on master
  • fix cs
  • push

So there is no need to create extra notes.

@vitek-rostislav vitek-rostislav changed the title Add FQN @param, @return and @var everywhere [shopsys] add FQN @param, @return and @var everywhere Nov 6, 2018
@vitek-rostislav vitek-rostislav merged commit 63eaa67 into master Nov 6, 2018
@vitek-rostislav vitek-rostislav deleted the tv-applied branch November 6, 2018 10:23
grossmannmartin added a commit to shopsys/demoshop that referenced this pull request Dec 12, 2018
- added missing @param and @return annotations through the whole codebase
- see shopsys/shopsys#573
grossmannmartin added a commit to shopsys/demoshop that referenced this pull request Dec 13, 2018
- added missing @param and @return annotations through the whole codebase
- see shopsys/shopsys#573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants