Rubocop, my old friend #1254
Merged
Rubocop, my old friend #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah shoes hasn't been very active recently, but we might pick it up again 💪 Thanks for the help! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow, a year and a half between rubocop commits.
I regenerated
.rubocop-todo.ymlwith the newest rubocop.Unfortunately rubocop has some bugs in how it handles exclusions in the todo file, causing not all cops in the todo file to be properly ignored. The other fixes in this PR address those cops to make all rubocop checks pass again.
Also filed a bug with rubocop for the false positive it's throwing on
shoes-core/lib/shoes/app.rbfor theStyle/VariableNumbercop and temporarily added the exclusion to.rubocop.yml#945