Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive on Style/VariableNumber #3699

Closed
jaredmoody opened this issue Nov 4, 2016 · 1 comment
Closed

False positive on Style/VariableNumber #3699

jaredmoody opened this issue Nov 4, 2016 · 1 comment

Comments

@jaredmoody
Copy link

I don't think the variable @__app__ should trigger this cop, but it does.

> rubocop -V                                                                                                                                  
0.45.0 (using Parser 2.3.1.4, running on jruby 2.3.1 java)
@jaredmoody jaredmoody mentioned this issue Nov 4, 2016
Merged
@bquorning
Copy link
Contributor

bquorning commented Nov 4, 2016 •
edited
Loading

This indeed looks like a bug.

Opened #3701 with a suggested fix.

bquorning added a commit to bquorning/rubocop that referenced this issue Nov 4, 2016
@bquorning
[Fix rubocop#3699] Fix false positive in VariableNumber
2058f03 
Style/VariableNumber would report false positives on variable names ending with
an underscore.
@bbatsov bbatsov closed this as completed in 2375b15 Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bquorning @jaredmoody