Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix short URL visits deletion when multi-segment slugs are enabled #1913

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 8, 2023

Closes #1900

Re-arrange route definitions so that short URL visits deletion matches before short URL deletion one when multi-segment slugs are enabled.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a4a107) 96.74% compared to head (8d35c1d) 96.74%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1913   +/-   ##
==========================================
  Coverage      96.74%   96.74%           
  Complexity      1313     1313           
==========================================
  Files            245      245           
  Lines           4551     4551           
==========================================
  Hits            4403     4403           
  Misses           148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit d6fedaf into shlinkio:develop Nov 8, 2023
32 of 33 checks passed
@acelaya acelaya deleted the feature/fix-delete-multi-segment-visits branch November 8, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting short URL visits does not work when multi-segment slugs are enabled
1 participant