Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting short URL visits does not work when multi-segment slugs are enabled #1900

Closed
acelaya opened this issue Oct 27, 2023 · 0 comments · Fixed by #1913
Closed

Deleting short URL visits does not work when multi-segment slugs are enabled #1900

acelaya opened this issue Oct 27, 2023 · 0 comments · Fixed by #1913
Labels
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Oct 27, 2023

Shlink version

All

PHP version

All

How do you serve Shlink

Other (explain in summary)

Database engine

MySQL

Database version

N/A

Current behavior

When the DELETE /short-urls/{shortCode}/visits endpoint is called while multi-segment slugs is enabled, the shortCode param ends up incorrectly including the /visits suffix.

I suspect this affects other routes as well.

Expected behavior

Short URL visits should be deleted

How to reproduce

N/A

@acelaya acelaya added the bug label Oct 27, 2023
@acelaya acelaya moved this to Todo in Shlink Oct 27, 2023
@acelaya acelaya added this to the 3.7.0 milestone Oct 27, 2023
@acelaya acelaya moved this from Todo to In Progress in Shlink Nov 5, 2023
@acelaya acelaya moved this from In Progress to In review in Shlink Nov 8, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant